This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Add minDelayOnEmptyResult in cache config #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShimmerGlass
force-pushed
the
min-duration-on-empty-result
branch
2 times, most recently
from
417277b
to
ff29a8c
Compare
In cache, when an empty response is received, wait at least minDelayOnEmptyResult before running the next request. If minDelayBetweenRequest is greater than minDelayOnEmptyResult, wait minDelayOnEmptyResult instead.
ShimmerGlass
force-pushed
the
min-duration-on-empty-result
branch
from
ff29a8c
to
63b4565
Compare
|
@rickfast Did you have time to take a look at this ? |
|
Thx :) Could you please release a version so we can import this change ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described here : hashicorp/consul#4810 blocking queries on missing services do not block when there is a lot of changes happening on a DC. While we want to keep
minDelayBetweenRequestsrelatively small, we would like to limit the rate of queries on missing services as they won't ever block (until the service is registered).In cache, when an empty response is received, wait at least minDelayOnEmptyResult before running the next request. If minDelayBetweenRequest is greater than minDelayOnEmptyResult, wait minDelayOnEmptyResult instead.